Run work in different thread #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14(Worker Push Notifications)
The problem
Some tasks that require a long execution time were blocking pika's ioloop which stop heartbeats to reach RabbitMQ. When RabbitMQ doesn't recive a heartbeat for a long time it considers the worker dead and resend the message, which create some duplicates because the worker did not die.
The solution
Runs the worker in a different thread so it can take as long as necessary while keeping his heart beating.
Obs.: Using this PR also requires to update Pika to 0.12.0